> On June 15, 2016, 6:55 p.m., Alexander Rukletsov wrote: > > src/module/manager.cpp, line 100 > > <https://reviews.apache.org/r/48733/diff/1/?file=1420039#file1420039line100> > > > > Did you leave out that 0.29.0 on purpose?
Fixed in an addendum commit: a1eb8b8df037aadbfa9cf60c70f8e8fda209138b - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48733/#review137802 ----------------------------------------------------------- On June 15, 2016, 6:59 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48733/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 6:59 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > After the decision to rename 0.29 to 1.0 we should > update comments and TODOs refering to 0.29. > Note we skipped comments which used 0.29 as a > target version. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > 2186f0e027946862783e739ece4acbc17dff7d6f > src/credentials/credentials.hpp 35918ef9a9b66d5ccbc3c7a490762319e6fc5445 > src/docker/executor.hpp d20a8fbbce57d4458e2162381e783f53d2c413fb > src/docker/executor.cpp 29bdb1b5a9078325b016cc5da8ab40002166e13d > src/launcher/executor.cpp 346aa30c50a21636ced5dfb33942d66feb4eb9c8 > src/master/allocator/mesos/metrics.hpp > 06fdd1633f63c005230e1cc5fafdad358a0ac254 > src/master/quota_handler.cpp 06cf0d3f24844ec9e884237db3f33145ff406e80 > src/module/manager.cpp 8b408bf1e3107c8c60953b9726fe78b903ec447e > src/slave/containerizer/docker.cpp bd4f5930684208d532f4ad1721aae353d309c0a7 > src/slave/flags.hpp 17acf56bc1905cb1173c575accfb9bda8abd1111 > src/slave/flags.cpp 7b0e347772646c177c1e18334633a71bc6cedb85 > src/tests/authorization_tests.cpp 217f36f38b589f6ee9df36c1c5d9b4fbb5b53033 > src/tests/master_quota_tests.cpp 62aaafe7b11a7df1ca7bc1f2f29af4cb626fc35d > > Diff: https://reviews.apache.org/r/48733/diff/ > > > Testing > ------- > > None: Not a functional change. > > > Thanks, > > Joerg Schad > >
