----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48769/#review137947 -----------------------------------------------------------
Patch looks great! Reviews applied: [45377, 36440, 48769] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 15, 2016, 11:51 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48769/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 11:51 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5341 > https://issues.apache.org/jira/browse/MESOS-5341 > > > Repository: mesos > > > Description > ------- > > The has_mode check is not needed as mode is a required field in > Volume protobuf. > > > Diffs > ----- > > src/docker/docker.cpp a6dcbe788abb8802baa2c70ec2fced1da75c7210 > > Diff: https://reviews.apache.org/r/48769/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
