----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48764/#review138025 -----------------------------------------------------------
src/slave/slave.cpp (lines 5434 - 5437) <https://reviews.apache.org/r/48764/#comment203243> If the entire `.then(..., [...](...) -> Future<bool> {` was on one line, then the lambda body contents would only be indented in two spaces from the `.then`, so I'd hope that the line-wrapping wouldn't affect that. I prefer wrapping before the `->` to wrapping after a `(` for a single argument. Would it be too weird to split the `[...]` from the `(...)`? ``` .then(defer(self(), [this, &frameworkId, &executorId] (const Owned<ObjectApprover>& sandboxApprover) -> Future<bool> { // Construct authorization object. ``` - Adam B On June 16, 2016, 8:14 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48764/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 8:14 a.m.) > > > Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-5615 > https://issues.apache.org/jira/browse/MESOS-5615 > > > Repository: mesos > > > Description > ------- > > Previously the sandbox authorization used the Request object based > authorization interface. Additionally this review fixes some issues > with sandbox authorization object handling in the LocalAuthorizer. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > 2186f0e027946862783e739ece4acbc17dff7d6f > src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 > > Diff: https://reviews.apache.org/r/48764/diff/ > > > Testing > ------- > > make check (OsX/macOs) > > > Thanks, > > Joerg Schad > >
