----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48801/#review138086 -----------------------------------------------------------
Ship it! src/log/log.hpp (line 111) <https://reviews.apache.org/r/48801/#comment203299> It might make sense for this to be a `Counter`, since the `recovered` promise should only ever go from not-ready to ready; not vice-versa. - Joseph Wu On June 16, 2016, 10:28 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48801/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 10:28 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5618 > https://issues.apache.org/jira/browse/MESOS-5618 > > > Repository: mesos > > > Description > ------- > > This is a gauge indicating if the replicated log has recovered or not. > > > Diffs > ----- > > include/mesos/log/log.hpp 9c8634987181b1345005619e6d16d738903c49fc > src/log/log.hpp 6e7577342d1ba93833e3445daf0f1e67ccc21a09 > src/log/log.cpp c0f1cb32a8447f457a4799f7c425a13343292889 > > Diff: https://reviews.apache.org/r/48801/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
