----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48745/#review138125 -----------------------------------------------------------
Patch looks great! Reviews applied: [48745] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 15, 2016, 7:48 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48745/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 7:48 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-5571 > https://issues.apache.org/jira/browse/MESOS-5571 > > > Repository: mesos > > > Description > ------- > > The major version check makes upgrading frameworks unnecessarily hard > because you would have to deploy Mesos and frameworks in lockstep. > > Dependency management should be done outside of the code but through > package metadata. > > > Diffs > ----- > > src/java/jni/convert.cpp 5c48ca89c376ea904e5dc37234495450b8d2255d > > Diff: https://reviews.apache.org/r/48745/diff/ > > > Testing > ------- > > make check passed, particularly Java related ones. > > > Thanks, > > Jiang Yan Xu > >
