-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48836/
-----------------------------------------------------------

(Updated June 17, 2016, 3:34 a.m.)


Review request for mesos, Gilbert Song, Guangya Liu, Jie Yu, and Vinod Kone.


Repository: mesos


Description
-------

Fixed variable shadowing in `launchTaskPosix`.


Diffs
-----

  src/launcher/posix/executor.cpp 76c7a267ec9fdaefe9b34a5f0cd55b893aafd280 

Diff: https://reviews.apache.org/r/48836/diff/


Testing (updated)
-------

```
pid_t launchTaskPosix(
    const mesos::v1::TaskInfo& task,
    const mesos::v1::CommandInfo& command,
    const Option<string>& user, <--- shadown with `Result<string> user = 
os::user();` below.
    char** argv,
    Option<char**>& override,
    Option<string>& rootfs,
    Option<string>& sandboxDirectory,
    Option<string>& workingDirectory)
```


Thanks,

haosdent huang

Reply via email to