> On May 5, 2016, 6:14 a.m., Zhiwei Chen wrote: > > Here I think it's ok in document, since -d supports raw data and a file > > path. But this patch makes the doc more friendly to beginners.
Indeed, both are fine. The only thing that concerns me is consistency across our examples; consistency is an important part of making our docs friendly to beginners : ). - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46872/#review131789 ----------------------------------------------------------- On May 2, 2016, 10:35 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46872/ > ----------------------------------------------------------- > > (Updated May 2, 2016, 10:35 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and haosdent huang. > > > Bugs: MESOS-5313 > https://issues.apache.org/jira/browse/MESOS-5313 > > > Repository: mesos > > > Description > ------- > > There should be a @ before the json file when using "curl -d". > > > Diffs > ----- > > docs/quota.md 797e134605381ae576d9aa93875e0314889ab047 > docs/weights.md 59d1579ed691524185c52ccd0bc26eadfbe167c2 > > Diff: https://reviews.apache.org/r/46872/diff/ > > > Testing > ------- > > root@mesos002:~/test# cat quota.json > { > "role": "role1", > "guarantee": [{ > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 1 > } > }, { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 128 > } > }] > } > > root@mesos002:~/test# curl -d @quota.json -X POST > http://192.168.56.12:5050/quota > > root@mesos002:~/test# curl -X GET http://192.168.56.12:5050/quota > 2>/dev/null|python -m json.tool > { > "infos": [ > { > "guarantee": [ > { > "name": "cpus", > "role": "*", > "scalar": { > "value": 1.0 > }, > "type": "SCALAR" > }, > { > "name": "mem", > "role": "*", > "scalar": { > "value": 128.0 > }, > "type": "SCALAR" > } > ], > "role": "role1" > } > ] > } > > > Thanks, > > Guangya Liu > >
