> On June 17, 2016, 6:20 a.m., haosdent huang wrote: > > src/tests/master_tests.cpp, line 2510 > > <https://reviews.apache.org/r/48450/diff/2/?file=1414177#file1414177line2510> > > > > Should we add > > ``` > > .WillRepeatedly(Return()); > > ``` > > here, may receive statusUpdate multiple times, right? > > Jay Guo wrote: > AFAIK, a successfully launched mock task only invokes statusUpdate once, > hence we shouldn't really expect multiple calls in this case.
I think we may receive TASK_RUNNING multiple tasks and TASK_FINISHED one time refer to https://github.com/apache/mesos/blob/master/src/tests/disk_quota_tests.cpp#L398-L400 But it looks OK for me because this test case passed in my local env. Let me drop this. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138168 ----------------------------------------------------------- On June 9, 2016, 11:13 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48450/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 11:13 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Add unit test for master /tasks endpoint. > > > Diffs > ----- > > src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e > > Diff: https://reviews.apache.org/r/48450/diff/ > > > Testing > ------- > > make check on Ubuntu 14.04 & OSX > > I didn't find unit test for this endpoint, therefore adding it. > > > Thanks, > > Jay Guo > >
