----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/#review138287 -----------------------------------------------------------
Fix it, then Ship it! I'll fix the issues for you. src/cli/execute.cpp (line 263) <https://reviews.apache.org/r/46762/#comment203462> I would take a vector<Volume> here src/cli/execute.cpp (lines 570 - 577) <https://reviews.apache.org/r/46762/#comment203461> I would move this check main.cpp. We should fail early, right? src/cli/execute.cpp (line 579) <https://reviews.apache.org/r/46762/#comment203466> Please use foreach - Jie Yu On June 14, 2016, 12:19 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46762/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 12:19 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5265 > https://issues.apache.org/jira/browse/MESOS-5265 > > > Repository: mesos > > > Description > ------- > > Enabled volume support for mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp 9b8f8a34fef4ac3225f0104a6a0acc1e43accd78 > > Diff: https://reviews.apache.org/r/46762/diff/ > > > Testing > ------- > > root@mesos002:~/src/mesos/m3/mesos/build# cat /root/test/volume4.json > [{ > "container_path":"\/tmp\/abc1", > "mode":"RW", > "source": > { > "docker_volume": > { > "driver":"convoy", > "name":"dvd1" > }, > "type":"DOCKER_VOLUME" > } > }, > { > "container_path":"\/tmp\/abc2", > "mode":"RW", > "source": > { > "docker_volume": > { > "driver":"convoy", > "driver_options": > {"parameter":[ > { > "key":"iops", > "value":"150" > } > ]}, > "name":"dvd2" > }, > "type":"DOCKER_VOLUME" > } > }] > > root@mesos002:~/src/mesos/m3/mesos/build# src/mesos-execute > --master=192.168.56.12:5050 --name=test --command="sleep 1000000" > --volumes=/root/test/volume4.json > I0428 21:27:52.406168 3775 scheduler.cpp:177] Version: 0.29.0 > Subscribed with ID '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-0003' > Submitted task 'test' to agent '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-S0' > Received status update TASK_RUNNING for task 'test' > source: SOURCE_EXECUTOR > > > Thanks, > > Guangya Liu > >
