----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48902/#review138389 -----------------------------------------------------------
I think we need move `master/allocator.proto` to `allocator/allocator.proto` as well. src/Makefile.am (line 704) <https://reviews.apache.org/r/48902/#comment203563> The indent of `\` incorrect here. src/Makefile.am (line 709) <https://reviews.apache.org/r/48902/#comment203564> I think we should create ``` v1allocator_HEADERS ``` and ``` nodist_v1allocator_HEADERS ``` to store `allocator/allocator.xx` seperately. - haosdent huang On June 18, 2016, 6:36 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48902/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 6:36 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5642 > https://issues.apache.org/jira/browse/MESOS-5642 > > > Repository: mesos > > > Description > ------- > > Move v1/master/allocator.proto to its own package. > > > Diffs > ----- > > include/mesos/v1/maintenance/maintenance.proto > 053d72d7d9fa9ec8f572136020546fa4f955ab09 > include/mesos/v1/master/allocator.proto > cf416d173bc487aecbbec75c9ee391a54bf5327b > src/CMakeLists.txt d66186217c1319d4497640614ed4beee28602c38 > src/Makefile.am a4931560f1a5b3fbe41ea181477341d3ac459b58 > > Diff: https://reviews.apache.org/r/48902/diff/ > > > Testing > ------- > > run `make` on Mac. > > > Thanks, > > Zhitao Li > >
