-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48909/
-----------------------------------------------------------
Review request for mesos, Isabel Jimenez, Jie Yu, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-5481
https://issues.apache.org/jira/browse/MESOS-5481
Repository: mesos
Description
-------
In this change, we change the `PerfFilter` use `PERF_` as match word
instead of `Perf`. This would resolve the match conflict of `Perf` in
`Registrar_BENCHMARK_Test.Performance`.
Diffs
-----
src/tests/containerizer/cgroups_tests.cpp
d766f0f0bfabd87904311d36f69aedf7651415b6
src/tests/containerizer/isolator_tests.cpp
7b4d47bd9e99b71269093d7c11559f3b74a3e22b
src/tests/containerizer/perf_tests.cpp
3dc5b0fa90dd941408a73585197b5309e3204576
src/tests/environment.cpp 0d22c4be42e2c3c53b2370be0c11544aea55621b
src/tests/slave_recovery_tests.cpp 2238355e9459cf4598a7aa96d3c6153a2dfcaa13
Diff: https://reviews.apache.org/r/48909/diff/
Testing
-------
1. Before apply the patch
```
# Install perf first.
sudo yum install perf
sudo MESOS_BENCHMARK=1 ./bin/mesos-tests.sh --gtest_filter="*Perf*"
--gtest_also_run_disabled_tests --gtest_list_tests
MesosContainerizerSlaveRecoveryTest.
CGROUPS_ROOT_PerfRollForward
PerfEventIsolatorTest.
ROOT_CGROUPS_Sample
CgroupsAnyHierarchyWithPerfEventTest.
ROOT_CGROUPS_Perf
PerfTest.
ROOT_Events
ROOT_Sample
Parse
SlaveCount/Registrar_BENCHMARK_Test. <- Incorrect
Performance/0 # GetParam() = 10000
...
# Then remove perf, `Registrar_BENCHMARK_Test` could not be filtered out
correctly.
sudo yum remove perf
sudo MESOS_BENCHMARK=1 ./bin/mesos-tests.sh --gtest_filter="*BENCH*"
--gtest_also_run_disabled_tests --gtest_list_tests
HierarchicalAllocator_BENCHMARK_Test.
...
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.
...
Tasks/SchedulerReconcileTasks_BENCHMARK_Test.
...
```
2. After apply the patch
```
# Install perf first.
sudo yum install perf
sudo MESOS_BENCHMARK=1 ./bin/mesos-tests.sh --gtest_filter="*PERF_*"
--gtest_also_run_disabled_tests --gtest_list_tests
MesosContainerizerSlaveRecoveryTest.
CGROUPS_ROOT_PERF_RollForward
PerfEventIsolatorTest.
ROOT_CGROUPS_PERF_Sample
CgroupsAnyHierarchyWithPerfEventTest.
ROOT_CGROUPS_PERF_PerfEvent
PerfTest.
ROOT_PERF_Events
ROOT_PERF_Sample
PERF_Parse
# Then remove perf, `Registrar_BENCHMARK_Test` could be filtered out correctly.
sudo MESOS_BENCHMARK=1 ./bin/mesos-tests.sh --gtest_filter="*BENCH*"
--gtest_also_run_disabled_tests --gtest_list_tests
sudo yum remove perf
HierarchicalAllocator_BENCHMARK_Test.
...
SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.
...
SlaveCount/Registrar_BENCHMARK_Test.
...
Tasks/SchedulerReconcileTasks_BENCHMARK_Test.
...
```
Thanks,
haosdent huang
