----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48917/#review138445 -----------------------------------------------------------
Patch looks great! Reviews applied: [48917] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 19, 2016, 12:19 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48917/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 12:19 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5172 > https://issues.apache.org/jira/browse/MESOS-5172 > > > Repository: mesos > > > Description > ------- > > The root cause for this issue is that, in private registry > like quay.io, layer download request will be redirected to > storage server in S3. However, the curl command with '-L' > handles HTTP redirection automatically, in which case HTTP > headers will be attached to all requests. AmazonS3 server > will return 400 Bad Request if HTTP Authorization header > is attached, with 'InvalidArgument' error code. So we need > to touch the given URL first to add extra logic for HTTP > redirections. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 211be6fdf416621c467faa5592c9e52a49b450ca > > Diff: https://reviews.apache.org/r/48917/diff/ > > > Testing > ------- > > make check > > Tested with quay.io/gilbertsong/inky manually. > > > Thanks, > > Gilbert Song > >
