> On June 11, 2016, 2:12 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 650-656
> > <https://reviews.apache.org/r/45363/diff/8/?file=1347662#file1347662line650>
> >
> > I see this method is different from the original one:
> > https://github.com/apache/mesos/blob/0.28.2/src/slave/containerizer/mesos/isolators/cgroups/mem.cpp#L66:L69
> >
> > Can you please let me know why you want to do this change?
I think it looks same?
```
static const vector<Level> levels()
{
return {Level::LOW, Level::MEDIUM, Level::CRITICAL};
}
```
I move the scope to `MemorySubsystem` because we put all `XXXSubsystem` in
`subsystem.cpp` currently. Define a global `levels()` looks not exactly.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45363/#review137119
-----------------------------------------------------------
On June 19, 2016, 10:31 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45363/
> -----------------------------------------------------------
>
> (Updated June 19, 2016, 10:31 a.m.)
>
>
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu,
> Kevin Klues, and Qian Zhang.
>
>
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add `MemorySubsystem` for cgroups unified isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION
> src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
