----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48924/#review138471 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.hpp (line 1078) <https://reviews.apache.org/r/48924/#comment203645> Should be `_filterWeights` here? src/master/weights_handler.cpp (lines 66 - 68) <https://reviews.apache.org/r/48924/#comment203646> I suggest to capture exactly here. ``` return _getWeights(principal) .then([request](const vector<WeightInfo>& weightInfos) -> Future<http::Response> { RepeatedPtrField<WeightInfo> filteredWeightInfos; ``` - haosdent huang On June 19, 2016, 12:01 p.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48924/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 12:01 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5495 > https://issues.apache.org/jira/browse/mesos-5495 > > > Repository: mesos > > > Description > ------- > > This patch refined the logic of collecting weights info in > WeightsHandler. Extracted the public code into new _getWeights > method so that the new operator API can reuse this method to > collect weight info. > > > Diffs > ----- > > src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d > src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e > > Diff: https://reviews.apache.org/r/48924/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
