----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48921/#review138475 -----------------------------------------------------------
src/slave/containerizer/mesos/launcher.cpp (line 94) <https://reviews.apache.org/r/48921/#comment203649> Typo: Meant to ask "Is there a valid case where we would be calling `fork` with `namespaces = 0` ? - Avinash sridharan On June 19, 2016, 5:10 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48921/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 5:10 a.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, haosdent huang, > and Kapil Arya. > > > Bugs: MESOS-5533 > https://issues.apache.org/jira/browse/MESOS-5533 > > > Repository: mesos > > > Description > ------- > > Posix launcher does not support namespaces. We should reject the launch > if namespaces are desired (e.g., from isolators). The currently behavior > of silently ignoring it will cause weird issues. > > > Diffs > ----- > > src/slave/containerizer/mesos/launcher.cpp > b1b323b4040fd72a7f01e60781eaf992e4ef766a > > Diff: https://reviews.apache.org/r/48921/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
