> On June 20, 2016, 12:34 a.m., Vinod Kone wrote: > > docs/upgrades.md, line 255 > > <https://reviews.apache.org/r/48928/diff/1/?file=1423596#file1423596line255> > > > > s/dependence/dependency/ ? > > > > esp the last occurence in this para.
I can make the change if you like, but what you propose (although colloquially used) is not technically correct english in the way I'm using it. A "dependence" is the thing you depend on. A "dependency" is the state of being dependent on something. I could say "Mesos 1.0 adds an external dependency to libmesos for `libelf` on Linux". And then "Please install this library before upgrading". Does that sound better? - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/#review138506 ----------------------------------------------------------- On June 19, 2016, 7:30 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48928/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 7:30 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and > Zhitao Li. > > > Bugs: MESOS-5630 > https://issues.apache.org/jira/browse/MESOS-5630 > > > Repository: mesos > > > Description > ------- > > Added info about external `libelf` dependence to `upgrades.md`. > > > Diffs > ----- > > docs/upgrades.md 61b7cd3ab45d09f3e4785e00bb8622421952d253 > > Diff: https://reviews.apache.org/r/48928/diff/ > > > Testing > ------- > > Ran the site docker to verify everything looked OK. > > > Thanks, > > Kevin Klues > >
