----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48976/#review138722 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On June 20, 2016, 11:34 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48976/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 11:34 p.m.) > > > Review request for mesos, Abhishek Dasgupta and Vinod Kone. > > > Bugs: MESOS-5494 > https://issues.apache.org/jira/browse/MESOS-5494 > > > Repository: mesos > > > Description > ------- > > This change removes the default values from the `Roles` > protobuf as it's _strictly_ a response type sent by the master > and it already has those values. Also, modified `weights` > to be a required field. > > > Diffs > ----- > > include/mesos/mesos.proto 54e3d1e278e745c09929c015410440eae4d47446 > include/mesos/v1/mesos.proto e644ce2c16e5677695df513c716c65d180e8e79d > src/master/http.cpp ccf0a4e1e6c6f004c7890cc142206f09e76a76c3 > > Diff: https://reviews.apache.org/r/48976/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
