----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48980/#review138767 -----------------------------------------------------------
Fix it, then Ship it! LGTM! Please drop that issue if not necessary. src/tests/common/http_tests.cpp <https://reviews.apache.org/r/48980/#comment203962> Not sure what it used to be. Curious if we want to add another `ip_addresses()` for `IPv6`, instead of removing it. src/tests/common/http_tests.cpp (line 254) <https://reviews.apache.org/r/48980/#comment203963> Not yours. May look better if the square bracket `[` is moved to next line, to make it consistant with above. - Gilbert Song On June 20, 2016, 9:17 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48980/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 9:17 p.m.) > > > Review request for mesos, Avinash sridharan, Gilbert Song, and Kapil Arya. > > > Repository: mesos > > > Description > ------- > > Removed the deprecated fields in NetworkInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 54e3d1e278e745c09929c015410440eae4d47446 > include/mesos/v1/mesos.proto e644ce2c16e5677695df513c716c65d180e8e79d > src/common/http.cpp 27b5d4add218fdc90744407f39d8690b1c87e457 > src/docker/executor.cpp a1fd5b1034ece415cc5805e12fc55816385ec71d > src/examples/test_hook_module.cpp 0f5f01530587b0223b57025a550aa83829c7fb48 > src/slave/slave.cpp 4bf01f2b020f5e975fb57cffcd19865d7431eac2 > src/tests/common/http_tests.cpp 14a521b2564be5cdb52be51426fc359627aeeaf1 > src/tests/containerizer/docker_containerizer_tests.cpp > 656cd72f10468f93ce2fc42de334d6fc0776f13a > src/tests/hook_tests.cpp 36b64dfbfa3baf51605e33dfafa448c419a35d27 > src/tests/master_tests.cpp a62d0abd8d574910998d01c2faec1c61973c686c > src/tests/slave_tests.cpp 5bb6322a241cb4b0e6a2a327ec07236229840a99 > > Diff: https://reviews.apache.org/r/48980/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >