----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49008/#review138787 -----------------------------------------------------------
The code looks good to me to replace stdin in subprocess by a temp file. But I dont understand how this relates to sending of an EOF. :( - Gilbert Song On June 20, 2016, 11:13 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49008/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 11:13 p.m.) > > > Review request for mesos and Avinash sridharan. > > > Bugs: MESOS-5592 > https://issues.apache.org/jira/browse/MESOS-5592 > > > Repository: mesos > > > Description > ------- > > This is to ensure that we send an EOF to the plugin. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 2206a86d12ace9ed86951bfd5ebdf79fe50db4e0 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 9fc709e95ecff7e97e159ed05a4efcf4e887d5e0 > > Diff: https://reviews.apache.org/r/49008/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
