----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48694/#review138869 -----------------------------------------------------------
Patch looks great! Reviews applied: [48692, 48693, 48694] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 21, 2016, 12:14 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48694/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 12:14 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > Rather than using `std::istringstream` and `std::ostringstream`, > instead use the facilities provided by Boost's UUID for input > and output respectively. This improves a simple benchmark that > uses `fromString` and `toString` by ~7x. > > > Diffs > ----- > > 3rdparty/stout/include/stout/uuid.hpp > a57896c78a35de677546ff7da116d669cfad1d66 > > Diff: https://reviews.apache.org/r/48694/diff/ > > > Testing > ------- > > make check > > Benchmark is here: > https://gist.github.com/anonymous/138d0333656871bddc2dfaa61fbf033e -- happy > to submit it as an RR as well (with cleanup), but I didn't think it was > warranted. > > > Thanks, > > Neil Conway > >
