----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46026/#review138960 -----------------------------------------------------------
Ship it! Thanks! Looks good modulo the setence on different behavior than BSD sockets, let me know if I'm missing something there. - Benjamin Mahler On June 20, 2016, 12:35 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46026/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 12:35 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Joris Van > Remoortere. > > > Repository: mesos > > > Description > ------- > > This is slightly confusing, because it doesn't match the > semantics of the shutdown(2) POSIX function. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 4cb49680d1304899a4ee675ac07379e51d9c55b1 > > Diff: https://reviews.apache.org/r/46026/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >