> On 六月 21, 2016, 8:22 p.m., Benjamin Mahler wrote: > > include/mesos/mesos.proto, line 281 > > <https://reviews.apache.org/r/48986/diff/1/?file=1425954#file1425954line281> > > > > We don't want to occupy a GPU agent and prevent GPU workloads from > > running, this adjustments looks incorrect? > > > > How about: > > > > ``` > > // Frameworks that are aware of GPU resources are expected to > > // avoid placing non-GPU workloads on GPU agents, in order to > > // avoid occupying a GPU agent and preventing GPU workloads > > // from running! Currently, if a ... > > ```
Thanks Ben, this is much better and I'm clear now. The previous sentense of `preventing GPU workloads from using precious GPU resources` looks a bit weird to me at first glance, but after your suggestion of `preventing GPU workloads from running`, I get the point of `preventing GPU workloads from using precious GPU resources`. Will update the comments to `preventing GPU workloads from running`. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48986/#review138925 ----------------------------------------------------------- On 六月 21, 2016, 2:14 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48986/ > ----------------------------------------------------------- > > (Updated 六月 21, 2016, 2:14 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Bugs: MESOS-5634 > https://issues.apache.org/jira/browse/MESOS-5634 > > > Repository: mesos > > > Description > ------- > > Updated a typo for GPU_RESOURCES. > > > Diffs > ----- > > include/mesos/mesos.proto e4bb313f9229f2101aa69acf82e367c01aeefb63 > include/mesos/v1/mesos.proto 8bba833c65c7f7b18fbdfe981280ef5d39f8c70b > > Diff: https://reviews.apache.org/r/48986/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
