> On 六月 21, 2016, 1:40 a.m., Vinod Kone wrote: > > src/master/master.hpp, line 1065 > > <https://reviews.apache.org/r/48925/diff/2/?file=1423780#file1423780line1065> > > > > move this handler to the outer Master class for consistency with other > > v1 API handlers.
Vinod, this method depends on a private _getWeights method in WeightsHandler, if we move this method to Master, will need to turn _getWeights as a public method, do I understand correctly? - zhou ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48925/#review138732 ----------------------------------------------------------- On 六月 20, 2016, 3:35 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48925/ > ----------------------------------------------------------- > > (Updated 六月 20, 2016, 3:35 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5495 > https://issues.apache.org/jira/browse/mesos-5495 > > > Repository: mesos > > > Description > ------- > > Add getWeights method in weights_handler. > > > Diffs > ----- > > src/master/http.cpp 148324e2c9d52f8211df4cead783e5a2979a45fe > src/master/master.hpp 50230397dcf52219fd4ed98dd1107bf53790478d > src/master/weights_handler.cpp 25075357c5ac8450d2fa1790844802f121908e9e > src/tests/api_tests.cpp d9596f35c2adfbb223c831136546bd854b19c320 > > Diff: https://reviews.apache.org/r/48925/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
