----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/#review139063 -----------------------------------------------------------
src/master/master.hpp (line 1131) <https://reviews.apache.org/r/48940/#comment204221> No sure whether use ``` process::Future<process::http::Response>_updateWeights( const Option<std::string>& principal, const google::protobuf::RepeatedPtrField<WeightInfo>& weightInfos) const; ``` would be better or not. Need @vinodkone and @anandmazumdar helps to check this style. XD src/master/master.hpp (line 1133) <https://reviews.apache.org/r/48940/#comment204219> I think could use `__updateWeights` instead of `_doUpdateWeights`. - haosdent huang On June 22, 2016, 5:20 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48940/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 5:20 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5496 > https://issues.apache.org/jira/browse/mesos-5496 > > > Repository: mesos > > > Description > ------- > > This patch refined the logic of updating weights in WeightsHandler. > Extracted the public code into new _updateWeights method so that > the new operator API can reuse this method to update weights. > > > Diffs > ----- > > src/master/master.hpp fe57878dc59637459d5c5cdae0be2aa159133fa4 > src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 > > Diff: https://reviews.apache.org/r/48940/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
