> On June 23, 2016, 6:01 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1274 > > <https://reviews.apache.org/r/49070/diff/1/?file=1427345#file1427345line1274> > > > > Can we add a VLOG here similar to what we did in `attach`?
Sure we can. However the difference between `detach` and `attach` is, for `detach` we do not have the CNI network config JSON string (`networkConfigJson`), instead we only have the path (`networkConfigPath`). I think it is a bit strange to read the JSON from `networkConfigPath` just for VLOG (and we also need to handle the read failed case), so what about in VLOG, we just print the path (`networkConfigPath`) rather than the whole JSON string? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49070/#review139153 ----------------------------------------------------------- On June 22, 2016, 4:33 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49070/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 4:33 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-5310 > https://issues.apache.org/jira/browse/MESOS-5310 > > > Repository: mesos > > > Description > ------- > > Used checkpointed CNI network config during cleanup. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 8cf5fcb1e63873b2a3eca843130a361f25a6e825 > > Diff: https://reviews.apache.org/r/49070/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
