----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49132/#review139256 -----------------------------------------------------------
Patch looks great! Reviews applied: [49132] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 23, 2016, 6:08 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49132/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 6:08 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5684 > https://issues.apache.org/jira/browse/MESOS-5684 > > > Repository: mesos > > > Description > ------- > > When attaching its log file, the Master passes > the `FilesProcess` an authorization callback to > use when authorizing a principal to access that > file. This callback was previously not > threadsafe, capturing the master's `this` pointer > and synchronously executing one of the master's > member functions in the wrong execution context. > > This patch alters the callback to dispatch > execution of the member function to the master > process. > > > Diffs > ----- > > src/master/master.cpp 8def7156f4a05b39590321ce7743f7385a68bed0 > > Diff: https://reviews.apache.org/r/49132/diff/ > > > Testing > ------- > > `make check`, and manually tested that `/files/download` requests for the > master's log file are authorized correctly. > > > Thanks, > > Greg Mann > >
