----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48705/#review139317 -----------------------------------------------------------
include/mesos/v1/agent/agent.proto (line 81) <https://reviews.apache.org/r/48705/#comment204496> It was an oversight that `ListFiles` only had a single member `path` :-( We would like it to return all the fields that `jsonFileInfo()` does. Have a look at my comments on https://reviews.apache.org/r/48704 src/slave/http.cpp (lines 666 - 714) <https://reviews.apache.org/r/48705/#comment204497> We can use the `FilesError` type's to construct the response here and just have one public `browse` that does both `resolve()`/`authorize()`. - Anand Mazumdar On June 19, 2016, 8:38 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48705/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 8:38 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5514 > https://issues.apache.org/jira/browse/MESOS-5514 > > > Repository: mesos > > > Description > ------- > > Implemented LIST_FILES Call in v1 agent API. > > > Diffs > ----- > > include/mesos/v1/agent/agent.proto 5ac6d4c93a826f0e7a3654d7dcc02b16424f90ce > src/slave/http.cpp 77834111bf51b58ba5e12f262b725202f7d3a7bf > src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 > > Diff: https://reviews.apache.org/r/48705/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Dasgupta > >
