----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49206/#review139395 -----------------------------------------------------------
src/master/quota_handler.cpp (lines 215 - 230) <https://reviews.apache.org/r/49206/#comment204611> hmm. this stuff is duplicated from the other `status` overload. can you factor this out into a common method (`_status`) that both overloads can use? src/master/quota_handler.cpp (line 286) <https://reviews.apache.org/r/49206/#comment204612> this might have to be renamed to `__status` per the comment above. - Vinod Kone On June 24, 2016, 5 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49206/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 5 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5508 > https://issues.apache.org/jira/browse/MESOS-5508 > > > Repository: mesos > > > Description > ------- > > Implemented GET_QUOTA Call in v1 master API. > > > Diffs > ----- > > src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 > src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa > src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/49206/diff/ > > > Testing > ------- > > sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check > > > Thanks, > > Abhishek Dasgupta > >
