> On June 26, 2016, 8:31 a.m., Michael Park wrote: > > support/cpplint.patch, line 7 > > <https://reviews.apache.org/r/48728/diff/1/?file=1419713#file1419713line7> > > > > The trailing whitespaces are giving me issues in applying these > > patches. Could you rebase and remove the trailing whitespaces, please? Here > > and below.
I'm sorry. diff creates this trailing lines and I was not sure if it's safe to delete them. - Tomasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48728/#review139490 ----------------------------------------------------------- On June 26, 2016, 1:58 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48728/ > ----------------------------------------------------------- > > (Updated June 26, 2016, 1:58 p.m.) > > > Review request for mesos, Adam Berry, Benjamin Mahler, Michael Park, and Neil > Conway. > > > Repository: mesos > > > Description > ------- > > Generate `support/cpplint.patch` using following command: > ``` > PATCH="support/cpplint.patch" > FIRST_COMMIT=`git log --pretty=format:"%h" --diff-filter=A -- $PATCH` > git diff ${FIRST_COMMIT}..master support/cpplint.py > $PATCH > sed -i 's/[ \t]*$//' "$PATCH" > ``` > > > Diffs > ----- > > support/cpplint.patch 1dd69a03044c0c17ca4ee555c6c9d27ea043d4f0 > > Diff: https://reviews.apache.org/r/48728/diff/ > > > Testing > ------- > > ``` > git co $FIRST_COMMIT > git co HEAD@{1} $PATCH > git apply $PATCH > git diff --exit-code master support/cpplint.py > ``` > > > Thanks, > > Tomasz Janiszewski > >
