> On June 27, 2016, 12:36 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, lines 567-568 > > <https://reviews.apache.org/r/49225/diff/1/?file=1430128#file1430128line567> > > > > Do we need the explicit `static_cast` here? Why doesn't `CopyFrom()` > > work directly?
Did not quite get it: This error is inevitably coming if we use CopyFrom directly : no matching function for call to ‘google::protobuf::RepeatedPtrField<mesos::v1::Resource>::CopyFrom(mesos::Resources&) Are you suggesting any design change here?? - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49225/#review139506 ----------------------------------------------------------- On June 25, 2016, 6:52 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49225/ > ----------------------------------------------------------- > > (Updated June 25, 2016, 6:52 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5499 > https://issues.apache.org/jira/browse/MESOS-5499 > > > Repository: mesos > > > Description > ------- > > Implemented RESERVE_RESOURCES Call in v1 master API. > > > Diffs > ----- > > src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 > src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/49225/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Dasgupta > >
