----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49252/#review139582 -----------------------------------------------------------
Patch looks great! Reviews applied: [49252] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 27, 2016, 9:53 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49252/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 9:53 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Qian Zhang. > > > Bugs: MESOS-4697 > https://issues.apache.org/jira/browse/MESOS-4697 > > > Repository: mesos > > > Description > ------- > > This is the draft of the new implementation @qianzhang proposed: > > * Use single `Subsystem` object to manage all container informations > > The details of implementation have a lot of nits, but let us focus on > the high level design. If this is OK, I could discard the old way and > continue to complete this patch. > > > Diffs > ----- > > src/CMakeLists.txt ecdeee75abfca944bc2ac1da4962d8d50e236d2d > src/Makefile.am 61789a7603dac08a5f8ac4fe3d63b43e123ed98a > src/slave/containerizer/mesos/containerizer.cpp > d984efd4742ec084d66538c48a36ea768832324d > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49252/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
