----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49015/#review139599 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/slave/http.cpp (line 1158) <https://reviews.apache.org/r/49015/#comment204850> Should be `return InternalServerError(future.failure())`? - haosdent huang On June 27, 2016, 4:07 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49015/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 4:07 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5518 > https://issues.apache.org/jira/browse/MESOS-5518 > > > Repository: mesos > > > Description > ------- > > Implemented GET_CONTAINERS Call in v1 Agent API. > > > Diffs > ----- > > include/mesos/agent/agent.proto 8f5267367857f45dc5c9ab064b183c9c8f1703e9 > include/mesos/v1/agent/agent.proto 91fb55db004733c3c5bb42acc32f1afedbc208bb > src/internal/evolve.hpp a8648f54d1efcdfe74371ff6bdcd6f1fd893103a > src/internal/evolve.cpp f63d606bd2ab91cb093639831e2c7898927d1156 > src/slave/http.cpp c038bf0c9680ec86f77f1a27efeb7354a9e67627 > src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/49015/diff/ > > > Testing > ------- > > make check on Ubuntu 14.04 & OSX > > > Thanks, > > Jay Guo > >
