----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49262/#review139647 -----------------------------------------------------------
configure.ac (lines 2087 - 2088) <https://reviews.apache.org/r/49262/#comment204915> Instead of copying it, can you place this check first and the `with_network_isolator` check can be simplified to check `enable_netlink` plus some additional functions that's needed by network port mapping isolator? I think `nl_has_capability` was introduced in 3.2.25 or something, and only network port mapping isolator has this restriction. For getting stats, I don't think we need libnl 3.2.26 or higher. Ideally, enable_netlink only requires the default libnl3 on ubuntu/centos (which is 3.2.21 I believe). - Jie Yu On June 27, 2016, 1:03 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49262/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 1:03 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-5646 > https://issues.apache.org/jira/browse/MESOS-5646 > > > Repository: mesos > > > Description > ------- > > Added '--enable-netlink' into configure.ac. > > > Diffs > ----- > > configure.ac 321436beb8ad87bb5727932eb2943986fe558237 > > Diff: https://reviews.apache.org/r/49262/diff/ > > > Testing > ------- > > After running `bootstrap` script, the newly introduced flag > `"--enable-netlink"` will appear in the `configure` script: > > ``` > $ ../configure --help > `configure' configures mesos 1.0.0 to adapt to many kinds of systems. > ... > --enable-netlink enable netlink for transferring miscellaneous > networking information between the kernel space and > userspace processes default: no > ... > ``` > > > Thanks, > > Qian Zhang > >
