> On June 27, 2016, 2:20 a.m., Jay Guo wrote: > > src/tests/api_tests.cpp, lines 93-99 > > <https://reviews.apache.org/r/49226/diff/1/?file=1430131#file1430131line93> > > > > Move this to the first patch in this review chain and maybe generalize > > it and add to `tests/mesos.hpp`
We ended up inlining the function to avoid the duplications. Abhishek would file a followup ticket to clean it up from the rest of the files. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49226/#review139510 ----------------------------------------------------------- On June 27, 2016, 8:37 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49226/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 8:37 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5500 > https://issues.apache.org/jira/browse/MESOS-5500 > > > Repository: mesos > > > Description > ------- > > Implemented UNRESERVE_RESOURCES Call in v1 master API. > > > Diffs > ----- > > src/master/http.cpp d55aa05c76bb2b1fb17b795510fd50c021cdb995 > src/master/master.hpp 648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/49226/diff/ > > > Testing > ------- > > > Thanks, > > Abhishek Dasgupta > >
