> On June 27, 2016, 4:36 p.m., Zhitao Li wrote: > > include/mesos/v1/master/master.proto, line 287 > > <https://reviews.apache.org/r/48841/diff/5/?file=1430819#file1430819line287> > > > > Should we use `VersionInfo` for `version`?
right now agent only communicates a string version when it registers with the master. in the future, when it includes VersionInfo we can include that here. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48841/#review139593 ----------------------------------------------------------- On June 27, 2016, 9:01 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48841/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 9:01 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5491 > https://issues.apache.org/jira/browse/mesos-5491 > > > Repository: mesos > > > Description > ------- > > This patch added Agent protobuf message to: > 1. v1 message: v1/master/master.proto > 2. unversioned message: master/master.proto > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/48841/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
