----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49174/#review139680 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp (line 314) <https://reviews.apache.org/r/49174/#comment204977> How about making this const and using `.at()` instead of the `[]` operator? - Benjamin Mahler On June 24, 2016, 2:43 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49174/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 2:43 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, > Artem Harutyunyan, and Jie Yu. > > > Bugs: MESOS-5576 > https://issues.apache.org/jira/browse/MESOS-5576 > > > Repository: mesos > > > Description > ------- > > This can be used in a test to "break" a socket without libprocess's > explicit knowledge. For example, we can disable transmission on a > persistent link. The next message sent over that link will be dropped. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 9bae71246e751e491be5a989eea8aca29c9aa751 > > Diff: https://reviews.apache.org/r/49174/diff/ > > > Testing > ------- > > See end of chain. > > > Thanks, > > Joseph Wu > >
