----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49064/#review139732 -----------------------------------------------------------
include/mesos/v1/master/master.proto (line 207) <https://reviews.apache.org/r/49064/#comment205070> move this up after `get_tasks` (tag number 7)to make it consistent with the enum order. src/tests/api_tests.cpp (lines 1326 - 1327) <https://reviews.apache.org/r/49064/#comment205072> move this to #1344. src/tests/api_tests.cpp (line 1339) <https://reviews.apache.org/r/49064/#comment205074> i would split the update part into its own test for clarity. src/tests/api_tests.cpp (line 1340) <https://reviews.apache.org/r/49064/#comment205073> indent by 2 spaces. - Vinod Kone On June 28, 2016, 5:23 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49064/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 5:23 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5496 > https://issues.apache.org/jira/browse/mesos-5496 > > > Repository: mesos > > > Description > ------- > > Implemented updateWeights method in WeightsHandler. > > > Diffs > ----- > > include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 > include/mesos/v1/master/master.proto > 681ea1e638777059a6bf792435cbe526bc252f7a > src/master/http.cpp 9e6d291aff77bb39462375dfed5dc75f3719806f > src/master/master.hpp f16bccd0b72a8785d03290d11cd9b28d2990fd24 > src/master/validation.cpp 9120b71fc7725bdf7094aac6619d8aadcc352df5 > src/master/weights_handler.cpp 51c957f9ad278e60541b2bde3de2b6090a541ec4 > src/tests/api_tests.cpp 7eb179f300f7a7dc6bdc3425268e7cd2fc8299fe > > Diff: https://reviews.apache.org/r/49064/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
