----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49321/#review139867 -----------------------------------------------------------
include/mesos/master/master.proto (lines 283 - 284) <https://reviews.apache.org/r/49321/#comment205220> hmm. seeing `get_frameworks`, `get_agents` and then `orphan_tasks` seems a bit weird. maybe the one we were discussing earlier reads better? ``` message GetState { required TimeInfo start_time = 1; required TimeInfo elected_time = 2; repeated GetFrameworks.framework frameworks = 3; repeated GetFrameworks.framework completed_frameworks = 3; repeated FrameworkID unregistered_frameworks = 4; repeated GetAgents.Agent agents = 5; repeated Task orphan_tasks = 6; } ``` also i'm not really a big fan of `GetFrameworks.framework` and `GetAgents.Agent`. not sure if that is weird or pulling `Framework` and `Agent` into top level protos (at the same level as `Call` and `Response` or top level inside `Response`) is more weird. include/mesos/master/master.proto (line 319) <https://reviews.apache.org/r/49321/#comment205214> i updated these. can you rebase? - Vinod Kone On June 28, 2016, 3:07 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49321/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 3:07 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > GetState response protobuf. > > > Diffs > ----- > > include/mesos/master/master.proto 332261918a069f4e581bfc4d0fc14ce8c86c2617 > include/mesos/v1/master/master.proto > 681ea1e638777059a6bf792435cbe526bc252f7a > > Diff: https://reviews.apache.org/r/49321/diff/ > > > Testing > ------- > > `make` on Mac > > > Thanks, > > Zhitao Li > >
