----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49340/#review139879 -----------------------------------------------------------
Ship it! src/launcher/posix/executor.cpp (lines 112 - 113) <https://reviews.apache.org/r/49340/#comment205223> Can you pull the 'command string' onto one line? I find it easier when the quotes are on the same line. src/launcher/posix/executor.cpp (lines 185 - 186) <https://reviews.apache.org/r/49340/#comment205224> Can you have the 'user' on one line? (Quotes on the same line) src/launcher/posix/executor.cpp (lines 198 - 199) <https://reviews.apache.org/r/49340/#comment205225> Ditto here src/launcher/posix/executor.cpp (lines 232 - 233) <https://reviews.apache.org/r/49340/#comment205226> Ditto here. - Benjamin Mahler On June 28, 2016, 10:14 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49340/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 10:14 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes. > > > Repository: mesos > > > Description > ------- > > Used ABORT consistently in command executor. > > > Diffs > ----- > > src/launcher/executor.cpp 939a16571bd7123b9561483444880e12a04f4cd0 > src/launcher/posix/executor.cpp b393db6c0631b5b5c43fb4d3d9183d9100e31049 > src/launcher/windows/executor.cpp 81ae4b0a53b128f2d9621537bf359880aff625e9 > > Diff: https://reviews.apache.org/r/49340/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
