----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49341/#review139880 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/posix/executor.cpp (line 103) <https://reviews.apache.org/r/49341/#comment205227> Looks like the `strerror(errrno)` was lost (used to be captured via `perror`. - Benjamin Mahler On June 28, 2016, 10:14 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49341/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 10:14 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, and Ian Downes. > > > Repository: mesos > > > Description > ------- > > The setsid loop is not necessary. POSIX standard suggests that the pid > of the child should not be equal to any active process group id. > > > Diffs > ----- > > src/launcher/posix/executor.cpp b393db6c0631b5b5c43fb4d3d9183d9100e31049 > > Diff: https://reviews.apache.org/r/49341/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
