----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49344/#review139883 -----------------------------------------------------------
Ship it! src/launcher/executor.cpp (lines 363 - 364) <https://reviews.apache.org/r/49344/#comment205228> Mind putting the quotes on a single line? src/launcher/posix/executor.cpp (lines 73 - 77) <https://reviews.apache.org/r/49344/#comment205233> The naked `.get()` seems unfortunate but this does make the format easier to read. Wonder if you want to do: ``` Try<string> format = strings::format( "%s %s '%s'", os::Shell::arg0, os::Shell::arg1, command.value()); CHECK_SOME(format); commandString = format.get(); ``` Almost like we need an equivalent of `T* CHECK_NOTNULL(T*)` to make this easier: ``` commandString = CHECK_NOTERROR(strings::format( "%s %s '%s'", os::Shell::arg0, os::Shell::arg1, command.value())); ``` Just some food for thought. - Benjamin Mahler On June 28, 2016, 10:15 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49344/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 10:15 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, Ian Downes, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Removed 'override' flag in command executor. > > > Diffs > ----- > > src/launcher/executor.cpp 939a16571bd7123b9561483444880e12a04f4cd0 > src/launcher/posix/executor.hpp 76072454a93a4ecb58ff3666923fc593a4f26b2a > src/launcher/posix/executor.cpp b393db6c0631b5b5c43fb4d3d9183d9100e31049 > src/launcher/windows/executor.hpp eb37f929fc5f5994e109642c7bd56c148c68fd43 > src/launcher/windows/executor.cpp 81ae4b0a53b128f2d9621537bf359880aff625e9 > src/tests/slave_tests.cpp 6d80b2d819660123454c78f52e995b32926b0e5d > > Diff: https://reviews.apache.org/r/49344/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
