> On June 27, 2016, 3:41 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 745 > > <https://reviews.apache.org/r/49175/diff/1/?file=1429006#file1429006line745> > > > > Let's not bother with this anymore because it seems to have > > proliferated via being copied around and we should be checking this at the > > start of the libprocess test main. However, I'm not sure we'd even compile > > if this was false given it seems to correspond to whether we have pthread > > support.
Cleaned up the `ProcessTest.Exited` and `ProcessTest.InjectExited` too. > On June 27, 2016, 3:41 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 805-815 > > <https://reviews.apache.org/r/49175/diff/1/?file=1429006#file1429006line805> > > > > The status being satisfied does not necessarily entail that the exited > > message is delivered since settling the clock does not ensure that socket > > events are processed. > > > > Can you use a Future instead of the atomic_bool? Cleaned up the `ProcessTest.Exited` and `ProcessTest.InjectExited` too. > On June 27, 2016, 3:41 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, lines 860-861 > > <https://reviews.apache.org/r/49175/diff/1/?file=1429006#file1429006line860> > > > > Can you put these inside initialize, here and below? I ended up consolidating the various helper actors into one `RemoteLinkTestProcess`. I use this by simply calling `linkup` (can't conflict with `link`), `relink`, or `ping_linkee`. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49175/#review139658 ----------------------------------------------------------- On June 28, 2016, 4:30 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49175/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 4:30 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Gilbert Song, > Artem Harutyunyan, and Jie Yu. > > > Bugs: MESOS-5576 > https://issues.apache.org/jira/browse/MESOS-5576 > > > Repository: mesos > > > Description > ------- > > Adds tests which exercise "link" semantics against remote processes. > This includes detection of `ExitedEvents` when the process exits > as well as mixing "link" semantics. > > Includes a test case that emulates the failure observed in MESOS-5576. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 > 3rdparty/libprocess/src/tests/process_tests.cpp > 3fce6fc41faaa7b6e8a2a957e85de3de973a51ba > 3rdparty/libprocess/src/tests/test_linkee.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49175/diff/ > > > Testing > ------- > > See end of chain. > > > Thanks, > > Joseph Wu > >
