----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49377/#review140063 -----------------------------------------------------------
Patch looks great! Reviews applied: [49323, 49375, 49376, 49377] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 29, 2016, 1:49 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49377/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 1:49 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and > Michael Park. > > > Repository: mesos > > > Description > ------- > > Each DRFSorter tracks the total resources in the cluster. This means > that each sorter must be updated when the resources in the cluster have > changed, e.g., due to the creation of a dynamic reservation or a > persistent volume. In the previous implementation, the quota role sorter > was not updated for non-quota roles when a reservation or persistent > volume was created by a framework. This resulted in inconsistency > between the total resources in the allocator and the quota role sorter. > > This could cause several problems. First, removing a slave from the > cluster would leak resources in the quota role sorter. Second, certain > interleavings of slave removals and reserve/unreserve operations by > frameworks and via HTTP endpoints could lead to CHECK failures. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > c3639342335499a04a23147a4205f1b475c123fa > src/master/allocator/sorter/drf/sorter.cpp > 27d56f274c41bbabe6f2abbbcebd2c4eff52693e > src/tests/persistent_volume_endpoints_tests.cpp > 6c85e19eeaa69bf3a4e3077261331191db6eec06 > > Diff: https://reviews.apache.org/r/49377/diff/ > > > Testing > ------- > > make check on OSX and recent Arch Linux. > > > Thanks, > > Neil Conway > >
