-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49404/
-----------------------------------------------------------
(Updated June 29, 2016, 6:11 p.m.)
Review request for mesos, Benjamin Mahler and Artem Harutyunyan.
Changes
-------
Separated out the race fix into a smaller patch, which goes in the opposite
direction as this patch (adds vs removes pointers).
Changed this patch to remove all `Socket*`s.
Summary (updated)
-----------------
Changed the SocketManager to pass "Sockets" by value.
Bugs: MESOS-5748
https://issues.apache.org/jira/browse/MESOS-5748
Repository: mesos
Description (updated)
-------
`Sockets` is already a reference-counted `shared_ptr` under the covers.
By passing around `Sockets` by value, we avoid potentially deleting
a reference while the same reference is in use by another function.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp 9bae71246e751e491be5a989eea8aca29c9aa751
Diff: https://reviews.apache.org/r/49404/diff/
Testing
-------
make check (OSX)
3rdparty/libprocess/libprocess-tests
--gtest_filter="ProcessRemoteLinkTest.RemoteLink" --gtest_break_on_failure
--gtest_repeat=10000
Thanks,
Joseph Wu
