----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49416/#review140091 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On June 30, 2016, 1:10 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49416/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 1:10 a.m.) > > > Review request for mesos, Benjamin Mahler and Artem Harutyunyan. > > > Bugs: MESOS-5748 > https://issues.apache.org/jira/browse/MESOS-5748 > > > Repository: mesos > > > Description > ------- > > This fixes a rare race (segfault) between `link` and > `ignore_recv_data`. If the peer of the socket exits between > establishing a connection and libprocess queuing a `MessageEncoder`, > `ignore_recv_data` may delete the `Socket` underneath the `link`. > > This patch is meant to be easily backported. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 9bae71246e751e491be5a989eea8aca29c9aa751 > > Diff: https://reviews.apache.org/r/49416/diff/ > > > Testing > ------- > > make check (OSX) > > 3rdparty/libprocess/libprocess-tests > --gtest_filter="ProcessRemoteLinkTest.RemoteLink" --gtest_break_on_failure > --gtest_repeat=10000 > > > Thanks, > > Joseph Wu > >
