----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49419/#review140104 -----------------------------------------------------------
Fix it, then Ship it! Both issues can be fixed with TODO for now. src/master/http.cpp (lines 3225 - 3236) <https://reviews.apache.org/r/49419/#comment205405> Not necessarily part of this patch, but I wonder whether we should have authorization of who can see an orphan task, and if yes, how to do that when we don't have the `FrameworkInfo`. THis should be addressed with separate patch anyway, so I'm fine with a mere TODO for now. src/tests/api_tests.cpp (line 435) <https://reviews.apache.org/r/49419/#comment205404> Can we add some test logic to kill the task from scheduler, then verify it shows up in completed task instead? Alternatively, a TODO for verifying completed_tasks is good. I can help write the patch later. - Zhitao Li On June 30, 2016, 1:35 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49419/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 1:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Jay Guo, and Zhitao Li. > > > Bugs: MESOS-5493 > https://issues.apache.org/jira/browse/MESOS-5493 > > > Repository: mesos > > > Description > ------- > > The response now distinguishes between active tasks, completed tasks, > pending tasks and orphan tasks to make it easy for clients. > Consequently got rid of offset, limit and offset in the Call because > they don't make sense when we have multiple fields in the response. > > > Diffs > ----- > > include/mesos/master/master.proto 2e5d6eeb3a960e4f41c382d65321f18bb05ed6be > include/mesos/v1/master/master.proto > 93157d57dcc53b54fed2ebbc4772c689ddba2119 > src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 > src/master/validation.cpp 6939d0e6ac3dbddc10f0315bd0a696a1f71634e2 > src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 > > Diff: https://reviews.apache.org/r/49419/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
