-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49223/
-----------------------------------------------------------
(Updated June 30, 2016, 1:12 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Address benm's comments; remove checking against Text.
Summary (updated)
-----------------
Enhance value parsing.
Bugs: MESOS-5739
https://issues.apache.org/jira/browse/MESOS-5739
Repository: mesos
Description (updated)
-------
Enhance value parsing.
1. Did not support [1-2, [3-4]] as Ranges; it should be [1-2, 3-4].
2. Did not support {a{b, c}d} as Set; it should be {ab, cd}
3. Add TODO for checking Text against [a-zA-Z0-9_/.-]
Diffs (updated)
-----
src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b
src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354
Diff: https://reviews.apache.org/r/49223/diff/
Testing
-------
make && make check
Thanks,
Klaus Ma
