> On June 30, 2016, 3:24 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/ssl/utilities.cpp, line 237 > > <https://reviews.apache.org/r/49400/diff/1/?file=1433533#file1433533line237> > > > > I am not sure if this is a C-ism, but calling the variable like the > > `struct` and then having to explicitly disambiguate seems a bit messy to me.
Yeah, it was unfortunate naming from my side - revised.... - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49400/#review140171 ----------------------------------------------------------- On June 30, 2016, 12:19 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49400/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 12:19 a.m.) > > > Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris > Van Remoortere, and Lukas Loesche. > > > Bugs: MESOS-5724 > https://issues.apache.org/jira/browse/MESOS-5724 > > > Repository: mesos > > > Description > ------- > > Adds the ability to render a subject alternative name based on a given > IP address within a X509 certificate extension. Additionally the > libprocess test suite makes use of this feature. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/gtest.hpp 5435ddd > 3rdparty/libprocess/include/process/ssl/utilities.hpp ad9ec5d > 3rdparty/libprocess/src/ssl/utilities.cpp d23f462 > > Diff: https://reviews.apache.org/r/49400/diff/ > > > Testing > ------- > > make check on OSX and various linux distros. > > Functional testing by validating a rendered certificate; > > ``` > openssl x509 -text -noout -in "temp_cert_file_name" > ``` > > > Thanks, > > Till Toenshoff > >
