----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49420/#review140194 -----------------------------------------------------------
Fix it, then Ship it! LGTM! include/mesos/master/master.proto (line 321) <https://reviews.apache.org/r/49420/#comment205523> Can we add some documentation on `completed_frameworks` for posterity? src/master/http.cpp (line 1271) <https://reviews.apache.org/r/49420/#comment205511> Not yours: Would have been much more readable if we had made the argument name as `_framework`. - Anand Mazumdar On June 30, 2016, 2:09 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49420/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 2:09 a.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Zhitao Li. > > > Bugs: MESOS-5492 > https://issues.apache.org/jira/browse/MESOS-5492 > > > Repository: mesos > > > Description > ------- > > This change removes tasks and executors information from > GetFrameworks call because we can get that from GetTasks > and GetExecutors (not yet implemented) calls. > > > Diffs > ----- > > include/mesos/master/master.proto 2e5d6eeb3a960e4f41c382d65321f18bb05ed6be > include/mesos/v1/master/master.proto > 93157d57dcc53b54fed2ebbc4772c689ddba2119 > src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 > > Diff: https://reviews.apache.org/r/49420/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
