----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49503/#review140377 -----------------------------------------------------------
Patch looks great! Reviews applied: [49503] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 1, 2016, 10:12 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49503/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 10:12 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > EXPECT_CALL() should be invoked before the event that is expected to > occur. In a few places, EXPECT_CALL() was used in a way that might > theoretically race with the generation of the expected event. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > 57b1503f508304412b3d247f6ff7d5e49756fc57 > src/tests/master_tests.cpp ddbab7a64ffac9bc706f17e8feb4b27a75ef97b0 > src/tests/persistent_volume_tests.cpp > 5125a8da44759d1235fddac26e9eb5436c3d037b > src/tests/scheduler_event_call_tests.cpp > 2e46f2752a35d32ec805025f86954d6900060022 > src/tests/slave_recovery_tests.cpp 8e9254afcf798d5158ec8a2c2b4cddfe50fac3f1 > > Diff: https://reviews.apache.org/r/49503/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
